fix: avoid unhandled promise rejection in WKSession.send #770
Conversation
src/webkit/wkConnection.ts
Outdated
| this._rawSend(messageObj); | ||
| return result; | ||
| } catch (e) { | ||
| return Promise.reject(e); |
There was a problem hiding this comment.
I'm trying to wrap my head around this. Previously _rawSend was throwing synchronously. Now we reject and return the rejection. How could something not handling the previous rejection start handling the new one?
Aside from my confusion about what this is doing, I think just marking send as async would do the same thing, without needing the try-catch.
There was a problem hiding this comment.
Previously when the code threw exceptions synchronously it wouldn't be caught by send(...).catch(...) and would end up unhandled whereas now it's always wrapped in a promise.
Changed this to be async.
yury-s
force-pushed
the
convert-exception-to-promise
branch
from
b5836cc to
301a73d
Compare
| throw err; | ||
| } | ||
| return callFunctionOnPromise.then(response => { | ||
| }).then(response => { |
There was a problem hiding this comment.
await's will read better!
There was a problem hiding this comment.
let me take care of that separately
3 participants
No description provided.