Skip to content

feat: add Page.opener() to the API #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aslushnikov merged 2 commits into from
Feb 1, 2020
Merged

feat: add Page.opener() to the API #790

aslushnikov merged 2 commits into from
Feb 1, 2020

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Jan 31, 2020 •
edited
Loading

Fixes: #783

@yury-s yury-s marked this pull request as ready for review February 1, 2020 01:05
@yury-s yury-s changed the title feat: popup opener page feat: add Page.opener() to the API Feb 1, 2020
@aslushnikov
Copy link
Contributor

aslushnikov commented Feb 1, 2020

Great! Can we also have a test that checks for page.opener() to be null if the parent page gets closed?

@yury-s
Copy link
Member Author

yury-s commented Feb 1, 2020

Done. Added another test.

@aslushnikov aslushnikov merged commit 25f2a32 into microsoft:master Feb 1, 2020
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
@playwrightmachine @github-actions
feat(roll): roll to ToT Playwright (26-09-22) (microsoft#790)
4f423bf 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Expose page.target()

2 participants

@yury-s @aslushnikov