Fix env duplication on merged-usr systems #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On modern (merged-usr) Linux systems, `/bin`, `/sbin` and `/usr/sbin` are symlinks to `/usr/bin`. There is no point in reporting the same Python installation four times, so canonicalize search paths before searching. Before: Breakdown for finding Environments: ----------------------------------- GlobalVirtualEnvs : 17.412201ms Locators : 225.284494ms Path : 433.162905ms Workspaces : 2.161556ms Environments (41): ------------------ GlobalPaths : 14 LinuxGlobal : 16 VirtualEnvWrapper : 11 After: Breakdown for finding Environments: ----------------------------------- GlobalVirtualEnvs : 16.595382ms Locators : 223.759511ms Path : 313.276036ms Workspaces : 1.418024ms Environments (21): ------------------ GlobalPaths : 2 LinuxGlobal : 8 VirtualEnvWrapper : 11
|
@elprans |
@DonJayamanne, the Technically, symlinked Python prefixes aren't real distinct installations (which is the point of this PR), but if it's important to return an uncanonicalized executable path for some reason, we can narrow the scope of this change to just canonicalize |
|
@DonJayamanne, any feedback on the above? I've modified the tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On modern (merged-usr) Linux systems,
/bin,/sbinand/usr/sbinare symlinks to
/usr/bin. There is no point in reporting the samePython installation four times, so canonicalize search paths before
searching.
Before:
After: