Skip to content

Add support for Poetry along with some fixes to PyEnv, Conda #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 24, 2024

Conversation

DonJayamanne
Copy link
Collaborator

No description provided.

@DonJayamanne DonJayamanne changed the title Add support for Poetry Add support for Poetry along with some fixes to PyEnv, Conda Jun 24, 2024
@DonJayamanne DonJayamanne marked this pull request as ready for review June 24, 2024 03:42
@@ -18,8 +18,8 @@ pub enum PythonEnvironmentCategory {
Pyenv, // Relates to Python installations in pyenv that are from Python org.
GlobalPaths, // Python found in global locations like PATH, /usr/bin etc.
PyenvVirtualEnv, // Pyenv virtualenvs.
PyenvOther, // Such as pyston, stackless, nogil, etc.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, pyston, stackless, etc will be just marked as pyenv

{
envs.lock().unwrap().push(env);
} else if let Some(env) =
get_generic_python_environment(&executable, &path, &manager)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed get_pure_python_environment, there's just Pyenv and PyEnvVirtual now.

@DonJayamanne DonJayamanne merged commit d24cd7b into main Jun 24, 2024
24 checks passed
@DonJayamanne DonJayamanne deleted the poetry branch June 24, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants