Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Better distinguish override completions in tooltip #261

Open
jakebailey opened this issue Oct 15, 2018 · 1 comment
Open

Better distinguish override completions in tooltip #261

jakebailey opened this issue Oct 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@jakebailey
Copy link
Member

Right now, completions for function overrides look like:

image

I don't think that it's very clear that selecting this completion will actually fill out a full function rather than just completing the name for you (which is what jedi does with the same exact hint name). I think it'd be better to include some extra text in the tooltip, like:

image

To better show what the completion actually does.

@jakebailey jakebailey added the enhancement New feature or request label Oct 15, 2018
@jakebailey
Copy link
Member Author

FWIW, the above is just:

private CompletionItem ToOverrideCompletionItem(IOverloadResult o, ClassDefinition cd, string indent) {
    return new CompletionItem {
        label = o.Name + " (override)",
        insertText = MakeOverrideCompletionString(indent, o, cd.Name),
        kind = CompletionItemKind.Method
    };
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant