Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Implement rename functionality #4

Closed
MikhailArkhipov opened this issue Aug 31, 2018 · 4 comments
Closed

Implement rename functionality #4

MikhailArkhipov opened this issue Aug 31, 2018 · 4 comments
Assignees
@MikhailArkhipov
Labels
enhancement New feature or request
Milestone
Sep 2018

Comments

@MikhailArkhipov
Copy link

microsoft/vscode-python#1008
microsoft/PTVS#4693
@MikhailArkhipov MikhailArkhipov self-assigned this Aug 31, 2018
@MikhailArkhipov MikhailArkhipov mentioned this issue Aug 31, 2018
Closed
@MikhailArkhipov MikhailArkhipov added the enhancement New feature or request label Aug 31, 2018
@MikhailArkhipov
Copy link
Author

#16

@MikhailArkhipov MikhailArkhipov added this to the Sep 2018 milestone Sep 5, 2018
@MikhailArkhipov MikhailArkhipov mentioned this issue Sep 20, 2018
Closed
@brettcannon
Copy link
Member

Is this implemented in version 0.1.38.0? I just tried it and I keep getting:

[Error - 4:21:17 PM] Request textDocument/rename failed.
  Message: unknown document
  Code: -32000 
[object Object]

when trying to rename any variable in

def foo(x):
    w = x * 3
    y = w * 5
    return y

@MikhailArkhipov
Copy link
Author

It is. Looks like URI conversion fix was lost in merges. Restored - 1.40 should have the fix.

@brettcannon
Copy link
Member

Thanks! I have validated the fix.

@d3r3kk d3r3kk mentioned this issue Jan 18, 2019
Closed
@DonJayamanne DonJayamanne mentioned this issue Apr 5, 2019
Closed
MikhailArkhipov pushed a commit that referenced this issue Sep 16, 2019
@CTrando
Lint on no method argument, no self argument, no cls argument (#1510)
3ccb213 
* Egg and zip  (#1)

* Lint on no self argument (#4)

* Revert "Egg and zip  (#1)"

This reverts commit 0993674.

* Removing dead code

* refactoring

* More refactors

* Test refactors

* Update readme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sep 2018
Development

No branches or pull requests
2 participants
@brettcannon @MikhailArkhipov