-
Notifications
You must be signed in to change notification settings - Fork 133
100% CPU use by the Language Server on MacOS after the latest upgrade #568
Comments
We'd need to know the language server version between both, but I'm not sure they would differ. All versions of the extension download the newest version of the language server. Maybe if they did it manually, the older extension wouldn't have downloaded an update yet... |
I'm the guy behind the tweet. When I downgraded, I didn't touch that same code base for the rest of the day, only working on my day-to-day code bases, where no problem is. Using the large code base, I'm at a consistent 100% on both newest and previous version. So sorry for the trouble here, there most likely isn't any issue with the newest upgrade! |
No problem. On a large codebase, it's likely to take a while to "complete". The exception being symbols (workspace/document/outline) which should be available almost immediately, as well as completion for files that are already analyzed. For the most part, it should be usable even if it's still working. There's an in progress rework which should improve performance. |
Any ETA on the in-progress re-work? It's been running for near 24 hours now on the ~200MB codebase. If it was doing some kind of indexing, I would imagine it should be complete by now. This seems to be related to something else. I'm experiencing the same thing. |
It's not doing any indexing per se. The old algorithm is iterative and reanalyzes to build type information. This can get dicey in some situations where the number of types a given variable can be keeps growing and does fully complete, hence a rework of the core analysis itself (see #479 (comment)). We've attempted to curb it by adding limits, making things more strict, but got to the end of the rope. I don't want to give any hard dates, but you can observe progress here: https://github.com/Microsoft/python-language-server/issues?q=label%3AGA #546 closes many issues and introduces a new LS based on the new analysis, but it is not yet feature complete and will not be the default quite yet. |
@musayev-io - our schedule is public. If you install Zenhub extension to Chrome, you should see our milestones and projected beta availability of the new LS. Ex #568 (comment). Check |
I have the same issue on OSX on a repo I use every day. This makes the Python extension completely unusable (For example, trying to jump to a function definition in the same file doesn't ever complete). |
I have the same problem on OSX. Code Version 1.31.1 (1.31.1) |
Duplicate of #610 |
0.2.16 is now available on beta channel. "python.analysis.downloadChannel": "beta" |
Mikhail - I added this to my settings.json but it says "Unknown configuration setting" and the latest release I see is 2019.2.5558. Should I be putting this setting elsewhere? Thanks! |
It's undocumented, so VS Code will warn about it. You can ignore this warning for testing. |
Noted! I assume all the code is already in the 2019.2.5558 release? |
Language server is independent of the extension release and is compatible with that is currently out. |
You just need to reload VS Code to get the extension to download the new version. File bugs with analysis here. 😄 |
Feedback from Twitter: https://twitter.com/HenrikOssipoff/status/1090544805539651584
The text was updated successfully, but these errors were encountered: