Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Pass documentation sources based on client capabilities instead of custom initialization option #608

Closed
jakebailey opened this issue Feb 14, 2019 · 0 comments
Closed

Pass documentation sources based on client capabilities instead of custom initialization option #608

jakebailey opened this issue Feb 14, 2019 · 0 comments
Assignees
@jakebailey
Labels
feature: tooltips protocol LSP compliance
Milestone
March 2019.1

Comments

@jakebailey
Copy link
Member

Currently, we accept in our initialization options the markup kind to use for all calls. LSP has its own options given in the client capabilities for this, which we should use instead.

https://github.com/Microsoft/python-language-server/blob/037d2485f5b5de16eee87e7adff2e1efbca0b859/src/LanguageServer/Impl/Implementation/Server.cs#L127-L136

Each of those sources can be given their own documentation source.
@jakebailey jakebailey self-assigned this Feb 14, 2019
@jakebailey jakebailey mentioned this issue Feb 21, 2019
Closed
@jakebailey jakebailey added the protocol LSP compliance label Feb 25, 2019
@jakebailey jakebailey added this to the March 2019.1 milestone Mar 12, 2019
This was referenced Mar 14, 2019
Closed
Merged
jakebailey added a commit that referenced this issue Mar 20, 2019
@jakebailey
Clean up initialization configuration (#793)
446cb26 
For #720.
Fixes #608.
Fixes #678.

This is the first set of configuration cleanup changes. This is a backwards compatible change, and will work on the existing build of the extension.

A future PR will modify how searchPaths and get_search_paths.py work.
jakebailey added a commit to jakebailey/python-language-server that referenced this issue Nov 1, 2019
@jakebailey
Clean up initialization configuration (microsoft#793)
c99ff7b 
For microsoft#720.
Fixes microsoft#608.
Fixes microsoft#678.

This is the first set of configuration cleanup changes. This is a backwards compatible change, and will work on the existing build of the extension.

A future PR will modify how searchPaths and get_search_paths.py work.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakebailey jakebailey

Labels
feature: tooltips protocol LSP compliance
Projects
None yet
Milestone
March 2019.1
Development

No branches or pull requests
1 participant
@jakebailey