Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Python rename broken with new Language Server #896

Closed
h-bex opened this issue Apr 7, 2019 · 1 comment
Closed

Python rename broken with new Language Server #896

h-bex opened this issue Apr 7, 2019 · 1 comment

Comments

@h-bex
Copy link

h-bex commented Apr 7, 2019

Product and Version [VSCode]: 1.33.0
OS Version [Windows]: Windows 10 (Windows_NT x64 10.0.17763)
Target Platform or Language: Python
Installed Extensions: Python 2019.3.6352; Vim 1.3.0; IntelliCode

Steps to Reproduce / Scenario:

  1. Set "python.jediEnabled": true
  2. Open an empty folder an enter a new python file (see Attachement MyTestFile.py)
  3. Try to rename function function_to_be_renamed to renamed_function (set cursor to function name and press F2 enter new name and press Enter --> Rename works as specified.
  4. Set "python.jediEnabled": false; Reload the folder. Do the same steps as in Step 3: --> Nothing happens BUG
  5. Restart VSCode and repeat Step 3: --> Nothing happens BUG
  6. Set "python.jediEnabled": true again (NOTE: NO RELOAD REQUESTED) and repeat Step 3: --> Nothing happens *BUG
  7. Reload Window (Developer: Reload Window) and Repeat Step 3: --> rename works as specified.

NOTE: I first detected this bug with the Intellicode Extension (MicrosoftDocs/intellicode#84). This extension automatically sets "python.jediEnabled": false. This setting is a requirement of this extension.

MyTestFile.py.txt
IntelliCode-Output.txt
Python output window:
`Starting Microsoft Python language server.
[Info - 00:26:50] GetCurrentSearchPaths C:\Program Files\Python37\python.exe
[Info - 00:26:50] Python search paths:
[Info - 00:26:50] c:\program files\python37\dlls
[Info - 00:26:50] c:\program files\python37\lib
[Info - 00:26:50] c:\program files\python37
[Info - 00:26:50] c:\users\h-bex\appdata\roaming\python\python37\site-packages
[Info - 00:26:50] c:\program files\python37\lib\site-packages
[Info - 00:26:50] Configuration search paths:
[Info - 00:26:50] C:\Program Files\Python37\python37.zip
[Info - 00:26:50] C:\Program Files\Python37\DLLs
[Info - 00:26:50] C:\Program Files\Python37\lib
[Info - 00:26:50] C:\Program Files\Python37
[Info - 00:26:50] C:\Users\h-bex\AppData\Roaming\Python\Python37\site-packages
[Info - 00:26:50] C:\Program Files\Python37\lib\site-packages
[Info - 00:26:50] .
[Info - 00:26:50] C:\Program Files\Python37
[Info - 00:26:50] Microsoft Python Language Server version 0.2.44.0
[Info - 00:26:50] Initializing for C:\Program Files\Python37\python.exe
##########Linting Output - pylint##########


Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
`

@MikhailArkhipov
Copy link

Rename is not yet implemented in the new code base. This is reflected in known issues for the LS and the extension. The implementation is coming soon. Please see

#699
#577
#819

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants