This repository was archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2019
AlexanderSher
approved these changes
Apr 8, 2019
I understand this fixed several issues like #577, but I guess it hasn't been released yet, right? Where can I check releases to know when it is available (and if it is the case that I have a problem in my own environment)? |
It is released in the daily channel, but not in beta or stable yet as we'd like a bit more testing. |
Ok, thank you. |
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Fix microsoft#668 (partial) * Tests * Revert "Tests" This reverts commit 7ffc9db. * Partial * Part 2 * Part 3 * Part 4 * Part 4 * Part 5 * Analysis tests * Tests * Tests * Basic test * Tests * Tests * Tests * Tests * Tests * Linked variables * Tests * Tests * Tests * Merge issues * Fix merge issue * Basic single file * Handle closed files * Closed files * Tests * Tests * Fix 454 * Remove references on analysis change * Rename * Rename non-user code * Linter * Ref fix * Member expressions * Linter improvements * Tests * Definitions only for LHS * Add test * Add null checks and tests * Null checks * Fix variable leak in expressions with comprehensions * Temp * Fix scope lookup + test * Handle virtual space * Better handle nested sequence expression assignments * More extensive handling of RHS sequences * PR feedback * Enable test * Test stability * Don't collect references to library modules * Handle virtual envs * PR feedback * null check * Remove references in all modules * Add test * Perf improvement * Null check in tests * Store span rather than node * Fix AST associations with locations * Handle null nodes * Temp * Add AST to nodes * Variable refs * Null ref * Merge issues * Handle import * * Undo debug * Merge issues * Better handle variable * Null check * Better handle nested variables without location * Fix rename test * Usings * Fix merge conflict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
Fixes #454
Fixes #577
Fixes #645
Fixes #477
Fixes #829
Fixes #729
Fixes #830
Fixes #843
Fixes #865
ILocatedMember
.LocationInfo
up front instead relying of remember originating expressions.LocatedMember
base to python types.Although the change is large, 90% is plumbing ILocatedMember to types. The remaining is calling
ILocatedMember.AddReference
in strategic places.