This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Ensure builtins module is created synchronously #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
September 30, 2019 12:03
|
A few caching tests fail, weird. |
|
Seems to be unrelated. Like |
|
Combined with #1757 all pass |
jakebailey
approved these changes
Nov 16, 2019
|
Will leave #1697 open until confirmed. |
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Sync builtins creation * Sync builtins * Usings * Debug code
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Sync builtins creation * Sync builtins * Usings * Debug code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1697