Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix AbstractPropertyReturnTypeIgnored test #185

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Fix AbstractPropertyReturnTypeIgnored test #185

merged 3 commits into from
Oct 3, 2018

Conversation

MikhailArkhipov
Copy link

And split 3.5 test into 3.5 and 3.6 so it runs when 3.5 is not present

@@ -2425,7 +2425,7 @@ class C(object):


[TestMethod, Priority(0)]
public async Task TrueDividePython3X() {
public async Task TrueDividePython35() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can still have a one test, but provide version in parameter, similar to OverrideCompletions3X

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@MikhailArkhipov MikhailArkhipov merged commit 3fb9d77 into microsoft:master Oct 3, 2018
@MikhailArkhipov MikhailArkhipov deleted the tests branch October 5, 2018 05:11
jakebailey pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
Fix AbstractPropertyReturnTypeIgnored test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants