This repository was archived by the owner on Apr 14, 2022. It is now read-only.
mark abstract functions as such#191
Merged
MikhailArkhipov merged 1 commit intoOct 4, 2018
Merged
Conversation
| bool IsClassMethod { get; } | ||
| bool IsProperty { get; } | ||
| bool IsClosure { get; } | ||
| bool IsAbstract { get; } |
There was a problem hiding this comment.
Since these are public interfaces you may have to create IFunctionInfo2 deriving from IFunctionInfo and add property there. This way code that uses public LS extensibility API will continue working. Yes, there is at least one VS Code extension that uses the API.
lostmsu
force-pushed
the
features/AbstractFunctions
branch
from
b767c51 to
14ca3e4
Compare
Contributor
Author
|
@MikhailArkhipov , makes sense, updated with |
Contributor
Author
|
@MikhailArkhipov , any thoughts on tri-state? |
MikhailArkhipov
approved these changes
Oct 4, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…ions mark abstract functions as such
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
IsAbstractproperty toIFunctionInfoandFunctionInfo, that tells if the function is abstract or not.Note: should we consider using tri-state
bool?here? During analysis, until all decorators are analyzed,IsAbstractmay returnfalse, when the final analysis result will betrue(it is the case right now, as in many cases imports ofabcare processed after functions).