This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Propagate known parameter types to derived functions #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,3 +76,7 @@ csharp_new_line_before_finally = false | |||
| csharp_new_line_before_members_in_anonymous_types = false | |||
|
|
|||
| csharp_new_line_before_members_in_object_initializers = false | |||
|
|
|||
| dotnet_style_qualification_for_field = false:suggestion | |||
| dotnet_style_qualification_for_property = false:none | |||
There was a problem hiding this comment.
I'd rather keep these as they were. We are slowly converting code to C# 7+ so we do want to see suggestion/information for => style so we can fix them as we go.
There was a problem hiding this comment.
These are controlling "this." prefixing, not '=>'. PLS appears to use underscore instead of 'this.' for fields. I don't know what's the guidance for properties.
|
I'll merge and fix the editorconfig |
MikhailArkhipov
approved these changes
Oct 18, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…eterTypePropagation Propagate known parameter types to derived functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a set of derived functions to
FunctionInfo. Fills the set whenDDGencounters aFunctionDefinition.Whenever a call to some function is analyzed, it looks at the list of derived functions, and passes the call info along to them.
Also added some styles to .editorconfig
Fixes #194 .
Seems to reduce the total number of failing test cases (local run shows 32->29).
I could not understand if I needed to also requeue anything for analysis. Left a comment about it in the code.
The change might be incomplete, as the new code was not added to the case when
_callsWithClosure != nullinFunctionInfo.Call. I could not quickly understand that code.