This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix MutatingReferences test #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 17, 2018 09:44
jakebailey
reviewed
Oct 17, 2018
|
|
||
| namespace Microsoft.PythonTools.Analysis.Infrastructure.Extensions { | ||
| public static class HashSetExtensions { | ||
| public static void Add<T>(this HashSet<T> set, IEnumerable<T> items) { |
Member
There was a problem hiding this comment.
Isn't this just HashSet.UnionWith?
| AnalysisQueue.Enqueue(analyzable, priority); | ||
|
|
||
| if (doc is ProjectEntry entry) { | ||
| var reanalyzeEntries = Analyzer.GetAllModuleDependents(entry.ModuleName, false); |
Contributor
There was a problem hiding this comment.
This will most likely die on ptvsd again
Author
There was a problem hiding this comment.
Where did it die? Original code cycled, this one should not.
Author
|
Actually, we need to resolve #273 first |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #47
Note: #273 is related, but requires different fix.