Fix processing of forward references #304

MikhailArkhipov · 2018-10-24T05:47:58Z

Fixes #294

Implement ordered processing of functions and properties. If return type is not known, process walker for that function which, in turn, can process more.
Fix some comments and clean up code.

src/Analysis/Engine/Impl/Interpreter/Ast/AstAnalysisFunctionWalkerSet.cs

src/Analysis/Engine/Impl/Interpreter/Ast/NameLookupContext.cs

src/Analysis/Engine/Impl/Interpreter/Ast/AstAnalysisFunctionWalkerSet.cs

AlexanderSher · 2018-10-26T16:37:46Z

src/Analysis/Engine/Impl/Interpreter/Ast/AstAnalysisFunctionWalkerSet.cs

+        public void ProcessSet() {
+            // Do not use foreach since walker list is dynamically
+            // modified and walkers are removed as they are done.
+            while (_functionWalkers.Count > 0) {


var walkers = _functionWalkers.Values.ToArray(); _functionWalkers.Clear(); foreach (var walker in walkers) { walker.Walk(); }

Actually, the point is in keeping walkers in the array for recursive processing. We don't walk in order. Ex A calls B which calls D which calls C. We take A which then, when it needs return type of B will call ProcessFunction that needs to find B walker and process it. B walkers will cause ProcessFunction on D and then on C.

So if walker is removed b/c it was called in some chain, we don't want to walk it again so that's why there is no ToArray

Mikhail Arkhipov added 4 commits October 23, 2018 19:40

Walk

51da19c

Tests

381c930

Undo

993f8bd

Comments

99ee98a

AlexanderSher reviewed Oct 24, 2018

View reviewed changes

src/Analysis/Engine/Impl/Interpreter/Ast/AstAnalysisFunctionWalkerSet.cs Show resolved Hide resolved