This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Send telemetry on unhandled exceptions inside the AnalysisQueue #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed the event name to |
AlexanderSher
approved these changes
Dec 7, 2018
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…osoft#460) * Telemetrize unhandled AnalysisQueue exceptions * make the main exception the inner one instead * don't bother sending isTerminating, we always send false * rename function, event name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.
I've also reworked the telemetry for exception-type events to a common place. If the exception is an AggregateException, then the first inner exception is the "main" exception reported. The outer exception is also included, but in different fields. This makes it easier to group events by where the first exception thrown actually occurs rather than special casing it in some query later.
AggregateExceptions can of course contain more than one inner exception, but because the telemetry properties must be strings, we can't really represent them without encoding something to JSON first and then re-parsing it later. I'd rather not bother until we have a good reason to send a big blob in the telemetry events.
One thing I want feedback on: Isanalyzer.unhandledExceptionalright for the event name?