Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

PTVS integration #524

Merged
merged 11 commits into from
Jan 9, 2019
Merged

Conversation

AlexanderSher
Copy link
Contributor

No description provided.

AlexanderSher and others added 10 commits December 5, 2018 09:26
Fix microsoft#281: Support "go to definition" for namespace packages
Fix microsoft#466: Fix "go to definition" and resolving imports

The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages
- Fix microsoft#501: PTVS-LS Integration: Fix LS hanging during file changes
- Fix microsoft#502: PTVS-LS Integration: Add required *.py files to the vsix
@AlexanderSher AlexanderSher requested a review from huguesv January 8, 2019 22:34
<LaunchProvider>Standard Python launcher</LaunchProvider>
<InterpreterId>{2af0f10d-7135-4994-9156-5d01c9c11b7e}</InterpreterId>
<InterpreterVersion>2.7</InterpreterVersion>
<CommandLineArguments>"C:\Users\steve_000\AppData\Local\Python Tools\CompletionDB\Debug\12.0\2af0f10d-7135-4994-9156-5d01c9c11b7e\2.7" "C:\USERS\STEVE_000\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\12.0EXP\EXTENSIONS\MICROSOFT\PYTHON TOOLS FOR VISUAL STUDIO\2.1\CompletionDB"</CommandLineArguments>
Copy link
Contributor

@huguesv huguesv Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks like something that shouldn't be there (or needs to be updated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was copied as is. Do you know what this pyproj file is for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must have been so Steve can more easily use PTVS to edit the various scraper files. Looks like it can be deleted.

namespace Microsoft.PythonTools.Intellisense {
using AP = AnalysisProtocol;

// TODO: Move this class to Analysis and make it public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's an old comment, but is it still true? if not, you could remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we still need this refactoring in LS. At least it can be basis for the implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

<file src="scrape_module.py" target="lib/vs16" />
<file src="get_search_paths.py" target="lib/vs16" />
<file src="typing-stub.pyi" target="lib/vs16" />
</files>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this where the typeshed files will be included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I've completely forgotten about Typeshed. I can add it to nuget subfolder. How do we ship it in PTVS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some code that includes typeshed files in vsix in PTVS' Analysis.csproj

@huguesv
Copy link
Contributor

huguesv commented Jan 9, 2019

Went through it, skipping some files that looked like were moved over without modifications.

@AlexanderSher AlexanderSher merged commit 13d2202 into microsoft:ptvs Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants