-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
Fix microsoft#281: Support "go to definition" for namespace packages Fix microsoft#466: Fix "go to definition" and resolving imports The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages
- Fix microsoft#501: PTVS-LS Integration: Fix LS hanging during file changes - Fix microsoft#502: PTVS-LS Integration: Add required *.py files to the vsix
<LaunchProvider>Standard Python launcher</LaunchProvider> | ||
<InterpreterId>{2af0f10d-7135-4994-9156-5d01c9c11b7e}</InterpreterId> | ||
<InterpreterVersion>2.7</InterpreterVersion> | ||
<CommandLineArguments>"C:\Users\steve_000\AppData\Local\Python Tools\CompletionDB\Debug\12.0\2af0f10d-7135-4994-9156-5d01c9c11b7e\2.7" "C:\USERS\STEVE_000\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\12.0EXP\EXTENSIONS\MICROSOFT\PYTHON TOOLS FOR VISUAL STUDIO\2.1\CompletionDB"</CommandLineArguments> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks like something that shouldn't be there (or needs to be updated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was copied as is. Do you know what this pyproj
file is for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must have been so Steve can more easily use PTVS to edit the various scraper files. Looks like it can be deleted.
namespace Microsoft.PythonTools.Intellisense { | ||
using AP = AnalysisProtocol; | ||
|
||
// TODO: Move this class to Analysis and make it public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's an old comment, but is it still true? if not, you could remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we still need this refactoring in LS. At least it can be basis for the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
src/PTVS/Microsoft.PythonTools.Analyzer/Impl/Intellisense/OutOfProcProjectAnalyzer.cs
Outdated
Show resolved
Hide resolved
<file src="scrape_module.py" target="lib/vs16" /> | ||
<file src="get_search_paths.py" target="lib/vs16" /> | ||
<file src="typing-stub.pyi" target="lib/vs16" /> | ||
</files> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this where the typeshed files will be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I've completely forgotten about Typeshed. I can add it to nuget subfolder. How do we ship it in PTVS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some code that includes typeshed files in vsix in PTVS' Analysis.csproj
Went through it, skipping some files that looked like were moved over without modifications. |
No description provided.