Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Docstring converter #596

Merged
merged 12 commits into from
Feb 13, 2019
Merged

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Feb 12, 2019

Closes #548.

Still missing Google/Numpy style param/return/etc list parsing. I'm also not too happy with the code duplication in the markdown documentation source.

@jakebailey
Copy link
Member Author

Oops, accidentally hit "submit PR" early. Still a little bit to be done, but it works very well as it is.

@jakebailey jakebailey added this to the Feb 2019.1 milestone Feb 12, 2019
@jakebailey
Copy link
Member Author

@MikhailArkhipov Do you want this merged even without Numpy/Google style docstring support and the copying between plaintext/markdown doc sources?

@MikhailArkhipov
Copy link

Up to you. I think more features can be added in stages, doesn’t have to handle everything off the bat. If it handles typical cases, it is already way better than nothing :-)

@jakebailey
Copy link
Member Author

Fair enough. I'll spend a little time seeing if there's a way to make them a little more presentable (like how I handle :param: for n ow), then merge it in and make issues for those other parts.

@jakebailey jakebailey changed the title [WIP] Docstring converter Docstring converter Feb 12, 2019
@jakebailey jakebailey merged commit 87c46f9 into microsoft:master Feb 13, 2019
jakebailey added a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
Closes microsoft#548.

Still missing Google/Numpy style param/return/etc list parsing. I'm also not too happy with the code duplication in the markdown documentation source.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants