This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Treat default value None as nothing#680
Merged
Merged
Conversation
| if (src != null && dst is PythonType pt) { | ||
| pt.TrySetTypeId(dst.TypeId); | ||
| public static void TransferDocumentationAndLocation(this IPythonType s, IPythonType d) { | ||
| if (s != null && s != d && s is PythonType src && d is PythonType dst) { |
Contributor
There was a problem hiding this comment.
I think we don't need s != null check here. Pattern matching will fail for s == null
AlexanderSher
approved these changes
Feb 28, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Fix microsoft#604 * PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604
Treat default value None as nothing since it is not a parameter type but just says the parameter may be missing.