Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix #719: Scraper produces incorrect output for the Anaconda 2X builtin #733

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

AlexanderSher
Copy link
Contributor

Also:

  • fixed messaging for relative imports that go beyond top-level
  • made amount of tasks in PythonAnalyzer dependent on the number of CPU cores

@jakebailey
Copy link
Member

So with my example without an __init__.py, this now works:

image

However, if you type from . you don't get any completion for B. (It also shows the same unresolved-import message with an empty string like in #722, but I'm not sure if that's in scope.)

@AlexanderSher
Copy link
Contributor Author

No, the change was for the cases like from ..abc in the root.

@jakebailey
Copy link
Member

You're right, my example works in master. Sorry for the noise.

@jakebailey
Copy link
Member

This is likely also out of scope, but the exception that gets thrown when you do something like from ..B import b otu of the root gets eaten completely. It ends up causing an exception over in the indexer. Do we know why we're eating these exceptions?

@AlexanderSher
Copy link
Contributor Author

I'm not sure I understand what exception do you mean. Analysis error is shown in UI (red squiggles are from pylint):
image

@jakebailey
Copy link
Member

I mean before this patch, on master. If you were to write that same code, then an exception is thrown somewhere and never logged, and then causes exceptions elsewhere.

@AlexanderSher AlexanderSher merged commit 613f7eb into microsoft:master Mar 12, 2019
@AlexanderSher AlexanderSher deleted the Fix719 branch March 12, 2019 04:16
jakebailey pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
… 2X builtin (microsoft#733)

* Fix microsoft#719: Scraper produces incorrect output for the Anaconda 2X builtin

* Add Anaconda 3.7 to the tests interpreters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants