Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix OOB exception in imports #753

Merged
merged 15 commits into from
Mar 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analysis/Ast/Impl/Analyzer/Handlers/ImportHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private void HandleImport(ModuleName moduleImportExpression, NameExpression asNa
// "import fob.oar.baz" is handled as fob = import_module('fob')
if (asNameExpression != null) {
Eval.DeclareVariable(asNameExpression.Name, variableModule, VariableSource.Import, asNameExpression);
} else if (_variableModules.TryGetValue(importNames[0], out variableModule)) {
} else if (importNames.Count > 0 && _variableModules.TryGetValue(importNames[0], out variableModule)) {
var firstName = moduleImportExpression.Names[0];
Eval.DeclareVariable(importNames[0], variableModule, VariableSource.Import, firstName);
}
Expand Down
7 changes: 7 additions & 0 deletions src/LanguageServer/Test/CompletionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,13 @@ public async Task NoCompletionInOpenString() {
result.Should().HaveNoCompletion();
}

[TestMethod, Priority(0)]
public async Task NoCompletionBadImportExpression() {
var analysis = await GetAnalysisAsync("import os,.");
var cs = new CompletionSource(new PlainTextDocumentationSource(), ServerSettings.completion);
cs.GetCompletions(analysis, new SourceLocation(1, 12)); // Should not crash.
}

[TestMethod, Priority(0)]
public async Task NoCompletionInComment() {

Expand Down