This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix analysis_complete event name for now, send working MB for *nix platforms #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailArkhipov
approved these changes
Apr 8, 2019
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…atforms (microsoft#900) Because this event is created in the analyzer, I didn't use `Telemetry.CreateEvent`, which would have appended the prefix we need. Hardcode it for now until stuff can move into Core. (I tried moving it into Core but ran into strange build issues.) Also, send the working set size as well, since *nix platforms don't seem to support paged/peak paged at all. That'll need its own fix that's more complicated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this event is created in the analyzer, I didn't use
Telemetry.CreateEvent, which would have appended the prefix we need. Hardcode it for now until stuff can move into Core. (I tried moving it into Core but ran into strange build issues.)Also, send the working set size as well, since *nix platforms don't seem to support paged/peak paged at all. That'll need its own fix that's more complicated.