This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Skip bad fused cython functions during scrape #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSher
approved these changes
Apr 20, 2019
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740.
If
__default__is set on afused_cython_function, then trying to access__kwdefaults__will segfault (in cython <0.29.6). Check for this condition before using theinspectlibrary to look at the function.This will make it such that the functions like this will have an empty signature, which is wrong, but it's better than crashing entirely and triggering coredump collection/popups.
I'm looking for a way to inspect these functions and find the cython version; so far no luck. If I can find it, then I can make this conditional and on updated libraries not do this check. The shared libraries produced by cython contain the version number, but I'm not sure I want to try reading out the compiled files directly to look for it.
PRs to update affected libraries are ongoing.