-
Notifications
You must be signed in to change notification settings - Fork 102
Completed cv2.Error and cv2.error types #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I figured out my first point, I replaced import cv2.Error as Error
__all__ = ["Error"] and it all references properly now. As for the second point, I guess if you are going to use |
Can I get a review on this? |
@Avasam, thanks for this change and all your other recent cleanup work in this repo! :) |
I have completed the self-referencing
cv2.error
(mentioned in #213) and the missing modulecv2.Error
. I've done so by looking at the content during runtime.There's still two issues I'm not sure how to fix, suggestions are welcome.
Python language server in VSCode reportingError
asAny
if imported fromcv2
:Although the "Go to Definition" action still works.reportMissingModuleSource
and Pylint will reportno-name-in-module
withimport cv2.Error
:Pylint is somewhat excepted and can be worked around by adding
"cv2"
to theextension-pkg-allow-list
configuration. Pyright however, I am not sure.