fix(cli): fix cache not being used when there are no dependencies #9522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
34 tasks
kelset
approved these changes
Feb 11, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Looks like Beachball is having issues again: |
Contributor
This specific one might be our fault. We have a known race condition in our CI logic that can cause PRs to fail when run around the same time as our nightly publish. It is unexpected though, since this was not close to that time. Another case where we have seen these issues is if Beachball were to run into issues during publish, and not push results to our repository, but it looks like it did correctly push that. Need to take a closer look. |
Contributor
|
Seeing the same Beachball issue with #9491. Doing a |
Contributor
|
I think I've identified the issue, with c3d84b0. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonthysell
approved these changes
Feb 11, 2022
jonthysell
pushed a commit
to jonthysell/react-native-windows
that referenced
this pull request
Feb 15, 2022
This PR backports microsoft#9522 to 0.68. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
jonthysell
pushed a commit
to jonthysell/react-native-windows
that referenced
this pull request
Feb 15, 2022
This PR backports microsoft#9522 to 0.67. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
jonthysell
pushed a commit
to jonthysell/react-native-windows
that referenced
this pull request
Feb 15, 2022
This PR backports microsoft#9522 to 0.66. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
ghost
pushed a commit
that referenced
this pull request
Feb 15, 2022
…ies (#9549) This PR backports #9522 to 0.67. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Feb 15, 2022
…ies (#9548) This PR backports #9522 to 0.68. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Feb 15, 2022
…ies (#9550) This PR backports #9522 to 0.66. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
This addresses a perf regression in autolinking when there are no dependencies to link.
Resolves #9518
What
Instead of checking whether the dependencies cache is empty, check whether it was instantiated.
Testing
Microsoft Reviewers: Open in CodeFlow