Skip to content

Conversation

@DaveTryon
Copy link
Contributor

This PR adds the skeleton for the consolidation action, so that we can have multiple people work on it.
In scope for this PR:

  • Refactor command line arguments
  • Add new action
  • Plumbing to get action to run

Not in scope:

  • Add consolidation-specific args to the config (and their unit tests)
  • Implement the actual consolidation logic

@DaveTryon DaveTryon requested a review from a team as a code owner June 24, 2025 17:01
Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits!

@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@DaveTryon
Copy link
Contributor Author

/azp run

@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2025
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2025
@DaveTryon DaveTryon merged commit 448191b into main Jun 24, 2025
5 checks passed
@DaveTryon DaveTryon deleted the DaveTryon/add-consolidation-skeleton branch June 24, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants