Skip to content

Conversation

@DaveTryon
Copy link
Contributor

This Adds the config file for the Consolidate verb. The key new element is the ArtifactInfoMap, which ConfigSanitizer will now reject for the consolidate action if it's malformed.

This touches IConfiguration so it's technically an API breaking change, but I'm not sure we need to worry about that one. It'll be a minor version bump either way when we release the consolidate action (and we'll also need to add it to the API, but we have a separate story for that and won't merge it until after we have a better idea of the shape of the data.

@DaveTryon DaveTryon requested a review from a team as a code owner June 25, 2025 22:10
@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@DaveTryon
Copy link
Contributor Author

/azp run

@DaveTryon
Copy link
Contributor Author

Trying to jump-start CLA check

@DaveTryon DaveTryon closed this Jun 25, 2025
@DaveTryon DaveTryon reopened this Jun 25, 2025
@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@DaveTryon DaveTryon merged commit 9a39f15 into main Jun 25, 2025
7 checks passed
@DaveTryon DaveTryon deleted the DaveTryon/add-consolidation-config branch June 25, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants