Skip to content

Conversation

@sfoslund
Copy link
Member

@sfoslund sfoslund commented Jun 26, 2025

This PR adds some additional plumbing to the consolidate verb to parse the user provided ArtifactInfoMap and find all valid SBOMs that need to be validated/ consolidated. This PR has logic to account for a variety of flavors of SBOMs- spdx 2.2/3.0 and ADO/ CloudBuild

@microsoft microsoft deleted a comment from github-actions bot Jun 27, 2025
@microsoft microsoft deleted a comment from github-actions bot Jun 27, 2025
@sfoslund sfoslund marked this pull request as ready for review June 27, 2025 16:54
@sfoslund sfoslund requested a review from a team as a code owner June 27, 2025 16:54
@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@sfoslund
Copy link
Member Author

/azp run

@microsoft microsoft deleted a comment from github-actions bot Jun 27, 2025
@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@sfoslund sfoslund merged commit 1dc7f49 into main Jun 27, 2025
5 checks passed
@sfoslund sfoslund deleted the sfoslund/validatePlumbing branch June 27, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants