Skip to content

Conversation

@sfoslund
Copy link
Member

This can be an indication that a user's config file is not properly formatted, so we don't want it to get lost in the logs.

@sfoslund sfoslund requested a review from a team as a code owner July 11, 2025 19:51
@github-actions
Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me wants to make this an error, but let's start with warning and see how that works out

@sfoslund sfoslund enabled auto-merge (squash) July 11, 2025 20:10
@sfoslund sfoslund merged commit 50ae6c5 into main Jul 11, 2025
5 checks passed
@sfoslund sfoslund deleted the sfoslund/warn branch July 11, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants