Exit with appropriate exit code when providing version #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
/azp run |
DaveTryon
approved these changes
Aug 18, 2025
Contributor
DaveTryon
left a comment
DaveTryon
left a comment
There was a problem hiding this comment.
LGTM. It will probably need to be to the latest commit before it can be merged
Contributor
Author
I was going to rebase the PR, but it seems like its already based on the latest commit in |
Contributor
|
@GDWR Yep, my mistake. We had a commit on Friday and I mistakenly thought that it had merged after your base commit. Merging now. Thanks for the contribution! Version 4.1.1 should release later this week. Your change will probably be in release 4.1.2 (no ETA at the moment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates the handling of the
--version&versionsubcommand to exit immediately with a0(successful) exit code, in scenarios that the version is correctly output.1(failure) will still be emitted when the version cannot be retrieved correctly.I've noticed this while outputting debug information in pipelines, as it causes the task to fail. I can always ignore the unsuccessful exit
|| trueetc, but I think outputting the correct exit code would be ideal.I did have a look at utilising the "Args" return to carry the exit code back to
Program.csfor handling the exiting of the application in unified manner, but it feels like a misuse of "Args" as they're intended to be client driven. If this approach is desired, from the structure of the application I would suggest moving the handling of version into aVersionServiceto unify how the handling of commands and subsequent exit codes are across the application. As the version logic is already different to the rest in where it is handled, I did not think this refactor would be desired. I am happy to refactor into a service if that feels more appropriate.