refactor: fix IDE0073 require file header #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
changed the title
ryanbrandenburg
approved these changes
Sep 1, 2023
Contributor
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
This looks great to me, but I'm curious where the header to require is specified?
Member
Author
It's in Lines 459 to 460 in 9e9a918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE0073: Require file header (The description in
.editorconfigis incorrect)Part of #340
This change adds the license header to files that are currently missing it, and also removes our custom
Verify-LicenseHeader.ps1script. It's clear that it didn't cover everything, as we were missing some files.