Target E2E tests with net472 only on Windows #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
sfoslund
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While helping with #881, I noticed that the
Microsoft.Sbom.Targets.E2E.Testsproject was targetingnet472on non-windows platforms, but that none of them were actually running. Tests forLinux,macOS, andmacOS-arm64all produced the error message, with minor variation in the root path (line breaks added to make it simpler to read):The
Microsoft.Sbom.Targets.Testsproject already restricts net472 targeting to Windows. This PR simply brings the same pattern to the E2E tests. It doesn't actually change what tests are running, but explicitly identifies the effective state of the tests. This change is needed for #881 to proceed successfully.