Skip to content

Conversation

@pragnya17
Copy link
Contributor

Previous PR's added compliance standard validation for SPDX 3.0, however there were a few bugs and error handling issues that this PR targets.

The main outcomes from this PR are:

  1. Compliance standard input is validated to make sure the only valid value is NTIA and it can only be used with >= SPDX:3.0
  2. Errors are handled correctly and displayed in stdout
  3. Better unit testing + E2E testing

@pragnya17 pragnya17 requested a review from a team as a code owner March 26, 2025 19:03
@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@pragnya17 pragnya17 changed the title Refactor compliance standard validation Validate compliance standard for SPDX 3.0 Mar 26, 2025
@pragnya17
Copy link
Contributor Author

/azp run

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@pragnya17
Copy link
Contributor Author

/azp run

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

DaveTryon
DaveTryon previously approved these changes Apr 2, 2025
@pragnya17
Copy link
Contributor Author

/azp run

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions

This comment was marked as duplicate.

@pragnya17
Copy link
Contributor Author

/azp run

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@DaveTryon
Copy link
Contributor

/azp run

@pragnya17 pragnya17 merged commit c5c3981 into main Apr 3, 2025
5 checks passed
@pragnya17 pragnya17 deleted the ppandrate_complianceStandardValidation branch April 3, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants