Move spdx extensions to common utils and refactor SPDX 2.2 #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
Apr 2, 2025
DaveTryon
reviewed
Apr 2, 2025
…lity method unit tests
…ithub.com/microsoft/sbom-tool into ppandrate_moveSpdxExtensionsToCommonUtils
Contributor
Author
|
/azp run |
pragnya17
changed the title
DaveTryon
reviewed
Apr 3, 2025
DaveTryon
reviewed
Apr 3, 2025
Contributor
Author
|
/azp run |
1 similar comment
Contributor
Author
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azp run |
DaveTryon
reviewed
Apr 3, 2025
DaveTryon
reviewed
Apr 3, 2025
DaveTryon
reviewed
Apr 3, 2025
DaveTryon
reviewed
Apr 3, 2025
DaveTryon
previously approved these changes
Apr 3, 2025
Contributor
DaveTryon
left a comment
DaveTryon
left a comment
There was a problem hiding this comment.
Now that we're using constants for the comparison, we might be able to remove some tests
Contributor
Author
|
/azp run |
DaveTryon
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a larger effort to refactor the SPDX extensions in SPDX 2.2 and SPDX 3.0, this PR aims to move the non-extension method to a common utility class. It also removes the duplicates from the SPDX 2.2 project and utilizes the common utility methods. Future PRs will target refactoring for SPDX 3.0.