crash if log is used?

[jmecosta]

no actions from my side, just this crash after minutes for registering

Application: Scalar.exe
CoreCLR Version: 4.700.19.57202
.NET Core Version: 3.0.2
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.IOException: The process cannot access the file 'D:\prod\structures-master.git\logs\scalar_maintenance_service.log' because it is being used by another process.
at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle)
at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at System.IO.File.Open(String path, FileMode mode, FileAccess access, FileShare share)
at Scalar.Common.Tracing.LogFileEventListener.SetLogFilePath(String newfilePath) in E:\A_work\23\s\Scalar.Common\Tracing\LogFileEventListener.cs:line 41
at Scalar.CommandLine.RunVerb.Execute(ScalarEnlistment enlistment) in E:\A_work\23\s\Scalar\CommandLine\RunVerb.cs:line 61
at Scalar.CommandLine.ScalarVerb.ForExistingEnlistment.Execute(GitAuthentication authentication) in E:\A_work\23\s\Scalar\CommandLine\ScalarVerb.cs:line 615
at Scalar.CommandLine.ScalarVerb.ForExistingEnlistment.Execute() in E:\A_work\23\s\Scalar\CommandLine\ScalarVerb.cs:line 605
at Scalar.Program.<>c.

b__0_4(ScalarVerb verb) in E:\A_work\23\s\Scalar\Program.cs:line 94
at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult1 result, Action1 action)
at Scalar.Program.Main(String[] args) in E:\A_work\23\s\Scalar\Program.cs:line 51

[jrbriggs]

Thanks for the report, @jmecosta! We'll get this fixed up.

[derrickstolee]

no actions from my side, just this crash after minutes for registering

Hi @jmecosta. How did you collect this stack trace? I'm just curious about your user experience.

Exception Info: System.IO.IOException: The process cannot access the file 'D:\prod\structures-master.git\logs\scalar_maintenance_service.log' because it is being used by another process.

This seems like the Scalar.Service launched a scalar run <task> process. The tricky bit is that this should not be true, as the Scalar.Service should only launch one process at a time. Is there a chance that you had the log open in a text editor that may have had a handle open?

Also, could you run scalar list so we could see the list of registered repos? I'm concerned that maybe your repo is registered twice somehow.

@jrbriggs: I'm thinking that the best fix is to catch this exception when opening the _service.log and fall back to a _<timestamp>.log file, and finally no log file if we can't open a log file.

[jrbriggs]

@jrbriggs: I'm thinking that the best fix is to catch this exception when opening the _service.log and fall back to a _.log file, and finally no log file if we can't open a log file.

Agreed @derrickstolee

[jmecosta]

no actions from my side, just this crash after minutes for registering

Hi @jmecosta. How did you collect this stack trace? I'm just curious about your user experience.

at the moment the user experience is not that nice, left it on during the night

the stack come via the event log

Exception Info: System.IO.IOException: The process cannot access the file 'D:\prod\structures-master.git\logs\scalar_maintenance_service.log' because it is being used by another process.

This seems like the Scalar.Service launched a scalar run <task> process. The tricky bit is that this should not be true, as the Scalar.Service should only launch one process at a time. Is there a chance that you had the log open in a text editor that may have had a handle open?

yes i probably open it, but pretty sure i dont have it open anymore and the exceptions are still coming.

Also, could you run scalar list so we could see the list of registered repos? I'm concerned that maybe your repo is registered twice somehow.
registered only once.

@jrbriggs: I'm thinking that the best fix is to catch this exception when opening the _service.log and fall back to a _<timestamp>.log file, and finally no log file if we can't open a log file.

you should also make sure old logs get deleted frequently

[derrickstolee]

@jmecosta Could you attach the D:\prod\structures-master.git\logs\scalar_maintenance_service.log file to this issue, so we can see what was running concurrently using that file? Otherwise, you could email it to scalarsupport@service.microsoft.com. Thanks!

[derrickstolee]

@jmecosta I should also mention that you can stop this from happening for now by running scalar unregister in your repository.