Skip to content

ScalarVerb: remove ValidateScalarVersion() #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

derrickstolee
Copy link
Contributor

VFS for Git checks gvfs/config to see if the client version string matches the remote's configured minimum version. This part of the gvfs/config endpoint does not speak Scalar version numbers. Also, we don't need to force users to upgrade as much as we did in that scenario.

This also causes a warning during scalar clone:

WARNING: Unable to validate your Scalar version
Server not configured to provide supported Scalar versions

Delete this check, removing this noisy warning.

@derrickstolee derrickstolee requested a review from mjcheetham June 9, 2020 19:40
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@derrickstolee derrickstolee merged commit 7f3aea3 into microsoft:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants