Drop Scalar.Service on macOS #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the 20.10.178 release, we only promoted background maintenance via Git and cron for the Linux platform because it did not have a service project. We are now removing the service on macOS, so use the background maintenance on all platforms _except_ Windows. Signed-off-by: Derrick Stolee <[email protected]>
Signed-off-by: Derrick Stolee <[email protected]>
This pre-install check was only checking if Git processes were running, but that's not required for our installer. It reduces our installer wizard by one extra click. Signed-off-by: Derrick Stolee <[email protected]>
Before we delete the .plist files during install, make sure to clear away the previous services and related processes. Signed-off-by: Derrick Stolee <[email protected]>
Upon install, we can look for the Scalar-registered repos then run 'scalar run config' do update whatever config options we have updated since the last version. Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee
changed the title
jeffhostetler
approved these changes
Oct 28, 2020
Closed
derrickstolee
added a commit
that referenced
this pull request
Dec 17, 2020
In #458, we dropped the `Scalar.Service` application from the macOS platform and depended entirely on `git maintenance start` to initialize background maintenance. This had two issues: 1. The `cron`-based background maintenance does not sufficiently create a user environment for GCM Core to store credentials. This causes it to start loading pop-ups on the hour every hour for the `prefetch` task. This item is handled upstream as `ds/maintenance-part-4`, which creates platform-specific maintenance abilities, including macOS integration with `launchd`/`launchctl`. 2. The maintenance jobs don't look at the shared object cache! While we were depending on `git maintenance run --task=<task>` inside `scalar run <job>`, I forgot that `scalar run` sets `GIT_OBJECT_DIRECTORY` so something inside of `git maintenance run` needs to do the same. This is being answered by microsoft/git#301. As for Scalar, the only thing we need to do is consume this new version of Git and test that `git maintenance run` does the same thing as `scalar run`. Hold it to the same standards.
derrickstolee
added a commit
that referenced
this pull request
Mar 11, 2021
…r cleanups Brew updated their CLI. Hence, `scalar upgrade` is currently broken. Users will need to run `brew upgrade --cask scalar[-azrepos]` to upgrade to a version including this fix. Further, since #458 dropped the Scalar service, the _next_ upgrade will fail because the service is still registered, just not running. Relax the conditions there. I was also getting build failures locally around the internal verb parameters. They are no longer used, so just drop them. Keep the command-line reference around so we don't break compat with any potential consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ahead of this: Git v2.29.0.vfs.0.0 includes
git maintenance startwhich can do most of our background maintenance. We enabled that for the Linux platform since that platform never had a C# service. This allows us to also drop the service on macOS (and all native code for macOS!).Here are some other things that make this PR complete:
ConfigStepon all registered repositories. (We will run this on Linux as well in a later PR.)