[Armada] HTTP Code generation for PerNodePlacement#591
Open
iYzeee23 wants to merge 5 commits into
Open
Conversation
olegsych
reviewed
May 18, 2026
olegsych
approved these changes
Jun 4, 2026
olegsych
requested changes
Jun 15, 2026
olegsych
left a comment
Member
There was a problem hiding this comment.
Asked a question about this on the Swagger PR - why are we defining options as an int? I expected it to be an enum
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #591 +/- ##
========================================
Coverage 49.21% 49.21%
========================================
Files 391 391
Lines 18491 18491
Branches 1845 1845
========================================
Hits 9101 9101
Misses 9074 9074
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
olegsych
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IncludePlacementPropertiesto the node query REST APIs and exposes the returnedNodeInfo.PlacementPropertiesmap in generated client modelsincludePlacementPropertiesto generated node client methods:GetNodeInfoListAsyncGetNodeInfoAsyncIncludePlacementPropertiesNodeInfo.PlacementPropertiesasIReadOnlyDictionary<string, string>NodeInfoConverterto deserialize and serialize the placement properties dictionaryIncludePlacementPropertiesto generatedGet-SFNodeHTTP PowerShellPlacementPropertiesis populated only when callers opt in withIncludePlacementProperties=true; existing callers remain source-compatible because the new generated parameter has a default value