Skip to content

[Armada] HTTP Code generation for PerNodePlacement#591

Open
iYzeee23 wants to merge 5 commits into
microsoft:developfrom
iYzeee23:user/pesicpredrag/per-node-placement-http-code
Open

[Armada] HTTP Code generation for PerNodePlacement#591
iYzeee23 wants to merge 5 commits into
microsoft:developfrom
iYzeee23:user/pesicpredrag/per-node-placement-http-code

Conversation

@iYzeee23

@iYzeee23 iYzeee23 commented May 10, 2026

Copy link
Copy Markdown
Contributor
  • Summary
    • Regenerates the Service Fabric HTTP client and generated HTTP PowerShell surface for opt-in node placement properties
    • This picks up the Swagger change that adds IncludePlacementProperties to the node query REST APIs and exposes the returned NodeInfo.PlacementProperties map in generated client models
  • Changes
    • Added includePlacementProperties to generated node client methods:
      • GetNodeInfoListAsync
      • GetNodeInfoAsync
    • Updated generated HTTP requests to send IncludePlacementProperties
    • Added NodeInfo.PlacementProperties as IReadOnlyDictionary<string, string>
    • Updated NodeInfoConverter to deserialize and serialize the placement properties dictionary
    • Added IncludePlacementProperties to generated Get-SFNode HTTP PowerShell
    • Updated generated HTTP PowerShell help XML
  • Notes
    • This is generated code only. The runtime behavior and Swagger source are handled in the corresponding Service Fabric runtime and Swagger PRs
    • PlacementProperties is populated only when callers opt in with IncludePlacementProperties=true; existing callers remain source-compatible because the new generated parameter has a default value
  • SF and Swagger

@iYzeee23 iYzeee23 requested a review from a team as a code owner May 10, 2026 20:31
@olegsych olegsych self-assigned this May 12, 2026
Comment thread src/Client.Http/Client/Generated/INodeClient.cs Outdated
olegsych

This comment was marked as duplicate.

@olegsych olegsych left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a question about this on the Swagger PR - why are we defining options as an int? I expected it to be an enum

@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.21%. Comparing base (2e907c5) to head (54a3869).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #591   +/-   ##
========================================
  Coverage    49.21%   49.21%           
========================================
  Files          391      391           
  Lines        18491    18491           
  Branches      1845     1845           
========================================
  Hits          9101     9101           
  Misses        9074     9074           
  Partials       316      316           
Flag Coverage Δ
ubuntu-latest 48.07% <ø> (ø)
windows-latest 48.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants