Switching to @Async #705
Merged
Switching to @Async #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.1.x #705 +/- ##
=========================================
Coverage 56.18% 56.18%
Complexity 754 754
=========================================
Files 181 181
Lines 3186 3186
Branches 233 233
=========================================
Hits 1790 1790
Misses 1261 1261
Partials 135 135
Continue to review full report at Codecov.
|
chenrujun
requested review from
chenrujun
and removed request for
saragluna and
superrdean
chenrujun
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates from CompletableFuture to @async. CompletableFuture causes issues in Java 11 with more than 2 CPUs.