Remove short circuit in app.$process() if no routes found.
#396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhk97
changed the title
app.$process() short circuit if no routes found.app.$process() if no routes found.
heyitsaamir
reviewed
Nov 12, 2025
Collaborator
heyitsaamir
left a comment
heyitsaamir
left a comment
There was a problem hiding this comment.
This looks good. Can you add a test? And have you tested the behavior?
Contributor
Author
I've tested the behavior. Will add unit tests as well. |
Contributor
Author
|
#398 included unit tests in this PR. will wait for that to be checked in first |
Contributor
Author
|
Since #398 is merged, this PR should be good to merge. |
heyitsaamir
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #393
The returned
{ status: 200 }fromapp.$processis not handled by the plugin, and so the http response is not set causing the server to "hang". By not short circuiting, the program execution continues leading toonActivityResponseevent being called and the HTTP response being set to default status of 200.