Korean IME (v1.24+): Composing character visually hides the character to its right

[drvoss]

Windows Terminal version

Affected: v1.24.10621.0 and later
Not affected: v1.23.20211.0 and earlier

Input method

Microsoft Korean IME (Dubeolsik or Sebeolsik layout)

Steps to reproduce

1. Open Windows Terminal with any shell.
2. Switch input method to Korean IME.
3. Type rk then sk to produce 가나.
4. Move the cursor between 가 and 나 (press Left once).
5. Type e to begin composing ㄷ.

Expected behavior

Display shows 가ㄷ나 — the in-progress composition appears as an insertion, and 나 remains visible.

Actual behavior

Display shows 가ㄷ — 나 is visually hidden for the entire duration of the composition. It reappears only after the syllable is committed.

Root cause

Renderer::_PaintBufferOutput writes the tsfPreview overlay using ReplaceText (overwrite-style) at the cursor column. The original row is saved in scratch but the displaced character to the right of the cursor is never restored visually for the duration of the frame.

This regression was introduced by #19738, which caused the Korean IME to use TSF inline rendering for the first time (previously it used IMM32 with a floating composition window).

Proposed fix

After writing the composition text, walk the original row (scratch) from the cursor position, absorbing up to W whitespace columns (where W = composition width), and copying non-whitespace glyphs to the right of the composition text. This renders the composition as an insertion while preserving TUI box borders when trailing whitespace is available.

A fix is ready on: https://github.com/drvoss/terminal/tree/fix/korean-ime-composition-insert-rendering

This is a companion to #20038.

[DHowett]

Thank you so much for working on this. I'm ready to approve your changes "sight unseen," but I was wondering if you had a screen recording of the new behavior? I bet it looks very good.

[drvoss]

@DHowett Thanks so much! I've put together a short screen recording of the updated behavior below
https://1drv.ms/v/c/12e51c083b315a95/IQB4g4bqVXG5RZJsXIqIE3yeAbCuoAgpIeb4O_fBsy3UWMA?e=cb7jby

Because of the resolution, it's best to download the video and watch it locally for the clearest view.

I hope this gives a clearer picture of how it works in practice. Happy to answer any questions or make any final tweaks.