Rename RegisterTestFramework adapterFactory parameter to frameworkFactory (#5691)

Copilot · Youssef1313 · web-flow · commit 189406154b25 · 2025-06-04T12:58:50.000+02:00
Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: Youssef1313 &lt;31348972+Youssef1313@users.noreply.github.com&gt;
diff --git a/src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs b/src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs
@@ -47,11 +47,11 @@ public interface ITestApplicationBuilder
     /// Registers a test framework with the application builder.
     /// </summary>
     /// <param name="capabilitiesFactory">The factory method for creating test framework capabilities.</param>
-    /// <param name="adapterFactory">The factory method for creating a test framework adapter.</param>
+    /// <param name="frameworkFactory">The factory method for creating a test framework adapter.</param>
     /// <returns>The updated test application builder.</returns>
     ITestApplicationBuilder RegisterTestFramework(
         Func<IServiceProvider, ITestFrameworkCapabilities> capabilitiesFactory,
-        Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> adapterFactory);
+        Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> frameworkFactory);
 
     /// <summary>
     /// Builds the test application asynchronously.
diff --git a/src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.cs b/src/Platform/Microsoft.Testing.Platform/Builder/TestApplicationBuilder.cs
@@ -72,17 +72,17 @@ internal TestApplicationBuilder(
 
     public ITestApplicationBuilder RegisterTestFramework(
         Func<IServiceProvider, ITestFrameworkCapabilities> capabilitiesFactory,
-        Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> adapterFactory)
+        Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> frameworkFactory)
     {
-        Guard.NotNull(adapterFactory);
+        Guard.NotNull(frameworkFactory);
         Guard.NotNull(capabilitiesFactory);
 
         if (_testFrameworkFactory is not null)
         {
             throw new InvalidOperationException(PlatformResources.TestApplicationBuilderFrameworkAdapterFactoryAlreadyRegisteredErrorMessage);
         }
 
-        _testFrameworkFactory = adapterFactory;
+        _testFrameworkFactory = frameworkFactory;
 
         if (_testFrameworkCapabilitiesFactory is not null)
         {
diff --git a/src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt b/src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt
@@ -1 +1,3 @@
 #nullable enable
+Microsoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFramework(System.Func<System.IServiceProvider!, Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!>! capabilitiesFactory, System.Func<Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!, System.IServiceProvider!, Microsoft.Testing.Platform.Extensions.TestFramework.ITestFramework!>! frameworkFactory) -> Microsoft.Testing.Platform.Builder.ITestApplicationBuilder!
+*REMOVED*Microsoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFramework(System.Func<System.IServiceProvider!, Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!>! capabilitiesFactory, System.Func<Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!, System.IServiceProvider!, Microsoft.Testing.Platform.Extensions.TestFramework.ITestFramework!>! adapterFactory) -> Microsoft.Testing.Platform.Builder.ITestApplicationBuilder!

Original file line number	Diff line number	Diff line change
`@@ -72,17 +72,17 @@ internal TestApplicationBuilder(`
`72`	`72`
`73`	`73`	`public ITestApplicationBuilder RegisterTestFramework(`
`74`	`74`	`Func<IServiceProvider, ITestFrameworkCapabilities> capabilitiesFactory,`
`75`		`- Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> adapterFactory)`
	`75`	`+ Func<ITestFrameworkCapabilities, IServiceProvider, ITestFramework> frameworkFactory)`
`76`	`76`	`{`
`77`		`- Guard.NotNull(adapterFactory);`
	`77`	`+ Guard.NotNull(frameworkFactory);`
`78`	`78`	`Guard.NotNull(capabilitiesFactory);`
`79`	`79`
`80`	`80`	`if (_testFrameworkFactory is not null)`
`81`	`81`	`{`
`82`	`82`	`throw new InvalidOperationException(PlatformResources.TestApplicationBuilderFrameworkAdapterFactoryAlreadyRegisteredErrorMessage);`
`83`	`83`	`}`
`84`	`84`
`85`		`- _testFrameworkFactory = adapterFactory;`
	`85`	`+ _testFrameworkFactory = frameworkFactory;`
`86`	`86`
`87`	`87`	`if (_testFrameworkCapabilitiesFactory is not null)`
`88`	`88`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
`1`	`1`	`#nullable enable`
	`2`	`+Microsoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFramework(System.Func<System.IServiceProvider!, Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!>! capabilitiesFactory, System.Func<Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!, System.IServiceProvider!, Microsoft.Testing.Platform.Extensions.TestFramework.ITestFramework!>! frameworkFactory) -> Microsoft.Testing.Platform.Builder.ITestApplicationBuilder!`
	`3`	+REMOVEDMicrosoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFramework(System.Func<System.IServiceProvider!, Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!>! capabilitiesFactory, System.Func<Microsoft.Testing.Platform.Capabilities.TestFramework.ITestFrameworkCapabilities!, System.IServiceProvider!, Microsoft.Testing.Platform.Extensions.TestFramework.ITestFramework!>! adapterFactory) -> Microsoft.Testing.Platform.Builder.ITestApplicationBuilder!