Rename RegisterTestFramework adapterFactory parameter to frameworkFactory#5691
Merged
Conversation
…tory Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename RegisterTestFramework adapterFactory parameter
Rename RegisterTestFramework adapterFactory parameter to frameworkFactory
Jun 3, 2025
Youssef1313
approved these changes
Jun 3, 2025
Member
Youssef1313
left a comment
There was a problem hiding this comment.
LGTM. @nohwnd I'll let you decide if you are okay with the super small break here.
Member
|
@copilot Fix these two errors: |
…name Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Contributor
Author
... Fixed the Public API analyzer errors. The issue was that the parameter rename created a breaking change that needed to be properly tracked:
This properly tracks the breaking change as an API removal + addition. Fixed in commit ee2de0f. |
Youssef1313
reviewed
Jun 3, 2025
Youssef1313
reviewed
Jun 3, 2025
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
nohwnd
approved these changes
Jun 4, 2025
drognanar
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
adapterFactoryparameter toframeworkFactoryin theMicrosoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFrameworkpublic API.Changes Made
adapterFactoryparameter toframeworkFactoryinITestApplicationBuilder.RegisterTestFrameworkmethod signatureTestApplicationBuilder.csto use the new parameter nameBreaking Change Impact
This is a code-breaking change for calls that use the parameter name explicitly (e.g.,
frameworkFactory: value). However, it is not a binary-breaking change - all existing code using positional parameters will continue to work without recompilation.Based on the analysis, major test frameworks (TUnit, NUnit, xUnit.net) do not use named parameters for this method, so the impact is minimal.
Rationale
The previous naming
adapterFactorywas leaking implementation details from MSTest's VSTest compatible implementation and did not fit the generic interface semantics. The new nameframeworkFactorybetter represents the purpose of this parameter in the generic testing platform context.Fixes #2443.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
8xbvsblobprodcus382.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)bcnvsblobprodcus378.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)i1qvsblobprodcus353.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)l49vsblobprodcus358.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)mfjvsblobprodcus373.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)s4uvsblobprodcus326.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)s8mvsblobprodcus38.vsblob.vsassets.iodotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj --configuration Release(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.