Add issue template.#3
Merged
codito merged 2 commits intomicrosoft:masterfrom Aug 31, 2016
codito:issuetemplate
Merged
Conversation
Contributor
Author
Contributor
|
@codito : Issue type looks new. Would folks fill that in appropriately or would we end up triaging all of these and adding our own tags irrespective? Everything else looks good. |
Contributor
Author
|
I hope contributors will fill the issue type. |
Haplois
added a commit
to Haplois/testfx
that referenced
this pull request
Nov 24, 2020
Evangelink
added a commit
that referenced
this pull request
Mar 20, 2026
- Fix #1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix #2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix #3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix #5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix #6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix #7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'
Evangelink
added a commit
that referenced
this pull request
Apr 21, 2026
- Replace ... placeholders in call-site expressions with <param> syntax
(e.g. <delta>, <expected>) for clarity
- Standardize all evidence labels to lowercase spaced format
(lowerBound → lower bound, ignoreCase → ignore case, etc.)
- Add actual value to IsExactInstanceOfType/IsNotExactInstanceOfType
- Make IsInstanceOfType and IsExactInstanceOfType wording parallel
('of type X (or derived)' vs 'exactly of type X')
- Fix IsInRange to use 5..10 range notation with expectations first
- Rename collection: to actual: in collection evidence blocks
- Add evidence blocks (collection values) to all CollectionAssert sections
that were missing them (Contains, DoesNotContain, IsSubsetOf, etc.)
- Add collection to HasCount and IsEmpty evidence blocks
- Fix Assert.That to use flat label format (no indented margin)
- Update backward compatibility: list Assert.Inconclusive as explicit
breaking change; note changes are part of MSTest v4
- Add 3 new unresolved questions from reviewer feedback:
#10 control character rendering strategy
#11 evidence block internal API
#12 collection multi-line rendering
- Expand unresolved question #3 (diff rendering) with inline highlight idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.