Skip to content

Remove Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " from extensions #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoRossignoli merged 6 commits into from
Aug 12, 2024
Merged

Remove Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " from extensions #3524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3f2e27
remove `Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' "`
engyebrahim Aug 12, 2024
0657e8f
Merge branch 'main' into Enji/entry-poin
engyebrahim Aug 12, 2024
29369c5
fix
engyebrahim Aug 12, 2024
c77c00b
Merge branch 'Enji/entry-poin' of https://github.com/microsoft/testfx…
engyebrahim Aug 12, 2024
b47abcd
reverse
engyebrahim Aug 12, 2024
981844f
reversr
engyebrahim Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ing.Extensions.CrashDump/buildMultiTargeting/Microsoft.Testing.Extensions.CrashDump.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
DO NOT CHANGE THE GUID, IT'S A WELL KNOWN EXTENSION POINT AND THIS EXTENSION NEEDS TO BE REGISTERED AT THE END
WE HAVE CODE INSIDE THE TASK 'TestingPlatformEntryPoint' TO ENSURE THE ORDER OF THE REGISTRATION BASED ON THIS GUID
-->
<TestingPlatformBuilderHook Include="EC3971EE-91B7-4C77-B4E1-DF606F118FAB" Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " >
<TestingPlatformBuilderHook Include="EC3971EE-91B7-4C77-B4E1-DF606F118FAB" >
<DisplayName>Microsoft.Testing.Extensions.CrashDump</DisplayName>
<TypeFullName>Microsoft.Testing.Extensions.CrashDump.TestingPlatformBuilderHook</TypeFullName>
</TestingPlatformBuilderHook>
Expand Down
2 changes: 1 addition & 1 deletion ...sting.Extensions.HangDump/buildMultiTargeting/Microsoft.Testing.Extensions.HangDump.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<Project>
<ItemGroup>
<TestingPlatformBuilderHook Include="8E989246-4E23-4AEF-9590-9B45485D3B7D" Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " >
<TestingPlatformBuilderHook Include="8E989246-4E23-4AEF-9590-9B45485D3B7D" >
<DisplayName>Microsoft.Testing.Extensions.HangDump</DisplayName>
<TypeFullName>Microsoft.Testing.Extensions.HangDump.TestingPlatformBuilderHook</TypeFullName>
</TestingPlatformBuilderHook>
Expand Down
2 changes: 1 addition & 1 deletion ...ing.Extensions.Telemetry/buildMultiTargeting/Microsoft.Testing.Extensions.Telemetry.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<Project>
<ItemGroup>
<TestingPlatformBuilderHook Include="98058041-B5B6-4A75-9834-58E6DF796A22" Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " >
<TestingPlatformBuilderHook Include="98058041-B5B6-4A75-9834-58E6DF796A22" >
<DisplayName>Microsoft.Testing.Extensions.Telemetry</DisplayName>
<TypeFullName>Microsoft.Testing.Extensions.Telemetry.TestingPlatformBuilderHook</TypeFullName>
</TestingPlatformBuilderHook>
Expand Down
2 changes: 1 addition & 1 deletion ...ing.Extensions.TrxReport/buildMultiTargeting/Microsoft.Testing.Extensions.TrxReport.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
DO NOT CHANGE THE GUID, IT'S A WELL KNOWN EXTENSION POINT AND THIS EXTENSION NEEDS TO BE REGISTERED AT THE END
WE HAVE CODE INSIDE THE TASK 'TestingPlatformEntryPoint' TO ENSURE THE ORDER OF THE REGISTRATION BASED ON THIS GUID
-->
<TestingPlatformBuilderHook Include="2006B3F7-93D2-4D9C-9C69-F41A1F21C9C7" Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " >
<TestingPlatformBuilderHook Include="2006B3F7-93D2-4D9C-9C69-F41A1F21C9C7" >
<DisplayName>Microsoft.Testing.Extensions.TrxReport</DisplayName>
<TypeFullName>Microsoft.Testing.Extensions.TrxReport.TestingPlatformBuilderHook</TypeFullName>
</TestingPlatformBuilderHook>
Expand Down
2 changes: 1 addition & 1 deletion ...oft.Testing.Platform.MSBuild/buildMultiTargeting/Microsoft.Testing.Platform.MSBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<!-- Register the PlatformOutputDevice extension -->
<ItemGroup>
<TestingPlatformBuilderHook Include="8214564B-6107-422D-8A82-462F97602287" Condition=" '$(GenerateTestingPlatformEntryPoint)' == 'True' " >
<TestingPlatformBuilderHook Include="8214564B-6107-422D-8A82-462F97602287" >
<DisplayName>Microsoft.Testing.Platform.MSBuild</DisplayName>
<TypeFullName>Microsoft.Testing.Platform.MSBuild.TestingPlatformBuilderHook</TypeFullName>
</TestingPlatformBuilderHook>
Expand Down