Skip to content

Disable out of process extensions in case of --list-tests #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoRossignoli merged 1 commit into from
Aug 29, 2024
Merged

Disable out of process extensions in case of --list-tests #3722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,16 +380,17 @@ await LogTestHostCreatedAsync(

// ======= TEST HOST ORCHESTRATOR ======== //
TestHostOrchestratorConfiguration testHostOrchestratorConfiguration = await TestHostOrchestratorManager.BuildAsync(serviceProvider);
if (testHostOrchestratorConfiguration.TestHostOrchestrators.Length > 0)
if (testHostOrchestratorConfiguration.TestHostOrchestrators.Length > 0 && !commandLineHandler.IsOptionSet(PlatformCommandLineProvider.DiscoverTestsOptionKey))
{
return new TestHostOrchestratorHost(testHostOrchestratorConfiguration, serviceProvider);
}

// ======= TEST HOST CONTROLLER MODE ======== //
// Check if we're in the test host or we should check test controllers extensions
// Environment variable check should not be needed but in case we will rollback to use only env var we will need it.
if (!testHostControllerInfo.HasTestHostController ||
if ((!testHostControllerInfo.HasTestHostController ||
systemEnvironment.GetEnvironmentVariable($"{EnvironmentVariableConstants.TESTINGPLATFORM_TESTHOSTCONTROLLER_SKIPEXTENSION}_{testHostControllerInfo.GetTestHostControllerPID(true)}") != "1")
&& !commandLineHandler.IsOptionSet(PlatformCommandLineProvider.DiscoverTestsOptionKey))
{
// Clone the service provider to avoid to add the message bus proxy to the main service provider.
var testHostControllersServiceProvider = (ServiceProvider)serviceProvider.Clone();
Expand Down