Ensure correct exit code in case of cancellation and add OnExit phase for for IPushOnlyProtocol#3820
Merged
Merged
Conversation
… for `IPushOnlyProtocol`
Evangelink
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the handling of test session cancellation and ensure proper disposal of resources in the
Microsoft.Testing.Platformproject. The most important changes include initializing theexitCodewith a default failure value, handling the cancellation token in various parts of theRunAsyncmethod, and adding a new method to theIPushOnlyProtocolinterface.Improvements to test session cancellation handling:
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs: InitializedexitCodewithExitCodes.GenericFailureand added checks fortestApplicationCancellationToken.IsCancellationRequestedto setexitCodetoExitCodes.TestSessionAbortedwhen necessary. [1] [2]Resource disposal enhancements:
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs: Added afinallyblock to callPushOnlyProtocol.OnExitAsync()ifPushOnlyProtocolis not null, ensuring proper cleanup.src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs: UpdatedDisposeServiceProviderAsyncto continue if the service is anIPushOnlyProtocol, ensuring it is not disposed prematurely.Interface and method additions:
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.cs: Added theOnExitAsyncmethod to theIPushOnlyProtocolinterface.src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.cs: Implemented theOnExitAsyncmethod to return a completed task.