Skip to content

Fix publishing as docker image via /t:PublishContainer #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 2 commits into from
Oct 14, 2024
Merged

Fix publishing as docker image via /t:PublishContainer #3929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fd668
Fix publishing as docker image via /t:PublishContainer
nohwnd Oct 10, 2024
cc351f2
Fix whitespace
nohwnd Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...t.Testing.Platform.MSBuild/buildMultiTargeting/Microsoft.Testing.Platform.MSBuild.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,4 +330,18 @@
</Target>

<Target Name="_TestRunStart" />

<Target Name="_SetTestingPlatformDefaultsForContainerBuild" BeforeTargets="ComputeContainerConfig"
Condition="'$(IsPublishable)' == 'true' AND '$(EnableSdkContainerSupport)' == 'true' AND !$(RuntimeIdentifier.StartsWith('win'))">
<!--
When PublishContainer target is used to create a docker image for the test project, it will try to write /app/TestResults folder
which is a non-writable folder. The environment variable below (notice double underscore) is used to override option defaults, and is picked up
EnvironmentVariablesConfigurationProvider.

ComputeContainerConfig is target that PublishContainer depends on to figure out the configuration for the container.
-->
<ItemGroup>
<ContainerEnvironmentVariable Include="platformOptions__resultDirectory" Value="/tmp/TestResults"></ContainerEnvironmentVariable>
</ItemGroup>
</Target>
</Project>