Fix typo in determining _TestArchitecture

[Youssef1313]

@Evangelink Worth backporting? Not sure if it can affect some arm64 scenarios

[Youssef1313]

This is a copy from line 339, but when it was copy-pasted, the condition was modified but the actual value is not. The code is meaningless on its current form.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (d141931) to head (de0e688).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5087      +/-   ##
==========================================
+ Coverage   66.11%   66.16%   +0.05%     
==========================================
  Files         605      605              
  Lines       36810    36810              
==========================================
+ Hits        24337    24357      +20     
+ Misses      12473    12453      -20     

Flag	Coverage Δ
Debug	66.16% <ø> (+0.05%)	⬆️
integration	66.16% <ø> (+0.05%)	⬆️
production	66.16% <ø> (+0.05%)	⬆️
unit	66.16% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

[Youssef1313]

@Evangelink This looks suspicious. I don't know how we can reach this "fallback" case. But if we do, I think we should use whatever dotnet we find from PATH and not force a specific architecture.

[Evangelink]

@MarcoRossignoli do you recall?

[Youssef1313]

#5091 suggests a larger change to how InvokeTestingPlatformTask work.

[Youssef1313]

Merging for now as-is and we can address this concern later if #5091 isn't going to happen soon.

[nohwnd]

I believe it was me who wrote some of the code in test anywhere repo and lot of the comments :) see 330, the _testArchitecture is used for log naming, we don't use it to influence which architecture will run, instead we just try to guess what is the architecture of the exe we run.

So when user builds for arm64 and runs they would see _arm64 in the log names, and not _x64.

[MarcoRossignoli]

If I recall well @nohwnd did this update, @nohwnd do you recall?

[nohwnd]

just posted above 1 min ago :)

[Youssef1313]

we don't use it to influence which architecture will run

The current implementation does that.

testfx/src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs

Line 172 in cd21e24

if (dotnetMuxerLocator.TryGetDotnetPathByArchitecture(targetArchitecture, out string? dotnetPath))

It tries to resolve dotnet by the _TestArchitecture defined.

[nohwnd]

#3703 that was introduced here, long time after the comment. So I stand corrected.

[Youssef1313]

Makes sense. Anyways, I think #5091 would be the ultimate path forward

[Youssef1313]

/backport to rel/3.8

[github-actions]

Started backporting to rel/3.8: https://github.com/microsoft/testfx/actions/runs/13499506395